chore: waits for a specific height instead of sleeping in the test for the emptiness of the first block

app/test/block_production_test.go

@@ -63,14 +63,14 @@ func (s *BlockProductionTestSuite) Test_FirstBlockIsEmpty() {
 	require := s.Require()
 	// wait until height 1 before posting transactions
 	// otherwise tx submission will fail
-	time.Sleep(1 * s.timeoutCommit)
-	// send some transactions, these should be included in the second block
-	_, err := s.cctx.PostData(s.accounts[0], flags.BroadcastBlock, appns.RandomBlobNamespace(), tmrand.Bytes(100000))
+	_, err := s.cctx.WaitForHeightWithTimeout(1, s.timeoutCommit)
+	require.NoError(err)
+	// send a transaction, it should be included in the second block
+	_, err = s.cctx.PostData(s.accounts[0], flags.BroadcastBlock, appns.RandomBlobNamespace(), tmrand.Bytes(100000))
 	require.NoError(err)
 
-	// wait for 2*s.timeoutCommit+1*time.Second to ensure that the node is
-	// at height 2
-	_, err = s.cctx.WaitForHeightWithTimeout(2, 2*s.timeoutCommit+1*time.Second)
+	// wait for height 2
+	_, err = s.cctx.WaitForHeightWithTimeout(2, s.timeoutCommit)
 	require.NoError(err)
 
 	// fetch the first block