chore: waits for a specific height instead of sleeping in the test for the emptiness of the first block #2284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds a test for emptiness of block 1 checks the content of block 1 adds timeoutCommit to the test suite struct adds a func description
This reverts commit cd4686e.
…eck-prepareproposal
…eck-prepareproposal
…eck-prepareproposal
…t-in-block-production-test
Merged
5 tasks
staheri14
added
the
chore
Codecov Report
@@ Coverage Diff @@
## main #2284 +/- ##
==========================================
- Coverage 20.63% 20.63% -0.01%
==========================================
Files 133 133
Lines 15344 15346 +2
==========================================
Hits 3166 3166
- Misses 11875 11877 +2
Partials 303 303
|
|
do we still want to pursue this or can we close? |
…t-in-block-production-test
|
The suggested changes by the reviewers seem to make the test flaky. I have spent some more time yesterday, yet the flakiness remains unchanged. We can ignore the PR for v1 release. If I could identify the reason of flakiness by the end of this week (and fix it), I'll mark it as ready for review, or will close it. Please let me know how does it sound to you? @evan-forbes |
|
sounds good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Addresses some of the remaining comments on #2233
Checklist