This repository has been archived by the owner on Mar 24, 2022. It is now read-only.
Make lucetc and lucet-validate errors more verbose #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iximeow
approved these changes
Jan 31, 2020
| ClifWasmError(#[from] ClifWasmError), | ||
| #[error("Lucet Module error")] | ||
| #[error("Lucet Module: {0}")] |
There was a problem hiding this comment.
this is definitely a "when we actually spec this out with tests" thought, but "Error: Lucet Module error: Unknown module for ..." ends up repeating that there's an error a bit more than we probably should 😅
acfoltzer
changed the title
acfoltzer
changed the title
acfoltzer
changed the title
cratelyn
approved these changes
Jan 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The full fix for these issues is tracked in #409, but this can merge first because it is already useful.