Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move experiment calculator to batch service #1160

Merged
merged 7 commits into from
Aug 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 0 additions & 42 deletions cmd/experimentcalculator/experimentcalculator.go

This file was deleted.

2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ require (
github.com/golang/protobuf v1.5.4
github.com/gomodule/redigo v2.0.0+incompatible
github.com/google/go-cmp v0.6.0
github.com/google/uuid v1.6.0
github.com/googleapis/gax-go/v2 v2.13.0
github.com/grpc-ecosystem/grpc-gateway/v2 v2.21.0
github.com/hashicorp/vault/api v1.14.0
Expand Down Expand Up @@ -91,7 +92,6 @@ require (
github.com/google/flatbuffers v23.5.26+incompatible // indirect
github.com/google/pprof v0.0.0-20240528025155-186aa0362fba // indirect
github.com/google/s2a-go v0.1.7 // indirect
github.com/google/uuid v1.6.0 // indirect
github.com/googleapis/enterprise-certificate-proxy v0.3.2 // indirect
github.com/gorilla/websocket v1.4.2 // indirect
github.com/hashicorp/errwrap v1.1.0 // indirect
Expand Down
24 changes: 24 additions & 0 deletions manifests/bucketeer/charts/batch/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,8 @@ spec:
value: "{{ .Values.env.nonPersistentRedis.poolMaxIdle }}"
- name: BUCKETEER_BATCH_NON_PERSISTENT_REDIS_POOL_MAX_ACTIVE
value: "{{ .Values.env.nonPersistentRedis.poolMaxActive }}"
- name: BUCKETEER_BATCH_EXPERIMENT_LOCK_TTL
value: "{{ .Values.env.experimentLockTTL }}"

volumeMounts:
- name: service-cert-secret
Expand Down Expand Up @@ -225,5 +227,27 @@ spec:
scheme: HTTP
resources:
{{ toYaml .Values.envoy.resources | indent 12 }}
- name: httpstan
image: "{{ .Values.httpstan.image.repository }}:{{ .Values.httpstan.image.tag }}"
imagePullPolicy: {{ .Values.httpstan.image.pullPolicy }}
ports:
- name: httpstan
containerPort: {{ .Values.httpstan.port }}
livenessProbe:
initialDelaySeconds: {{ .Values.health.initialDelaySeconds }}
periodSeconds: {{ .Values.health.periodSeconds }}
failureThreshold: {{ .Values.health.failureThreshold }}
httpGet:
path: {{ .Values.httpstan.healthPath }}
port: {{ .Values.httpstan.port }}
scheme: HTTP
readinessProbe:
initialDelaySeconds: {{ .Values.health.initialDelaySeconds }}
httpGet:
path: {{ .Values.httpstan.healthPath }}
port: {{ .Values.httpstan.port }}
scheme: HTTP
resources:
{{ toYaml .Values.httpstan.resources | indent 12 }}
strategy:
type: RollingUpdate
12 changes: 12 additions & 0 deletions manifests/bucketeer/charts/batch/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ env:
addr:
poolMaxIdle: 25
poolMaxActive: 25
experimentLockTTL: 10m

affinity: {}

Expand Down Expand Up @@ -88,6 +89,17 @@ oauth:
issuer:
audience:


httpstan:
image:
repository: ghcr.io/bucketeer-io/bucketeer-httpstan
tag: 0.0.1
pullPolicy: IfNotPresent
config:
port: 8080
healthPath: v1/health
resources: {}

service:
type: ClusterIP
clusterIP: None
Expand Down
23 changes: 0 additions & 23 deletions manifests/bucketeer/charts/experiment-calculator/.helmignore

This file was deleted.

5 changes: 0 additions & 5 deletions manifests/bucketeer/charts/experiment-calculator/Chart.yaml

This file was deleted.

This file was deleted.

This file was deleted.

Loading
Loading