feat: move experiment calculator to batch service #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ubisoft-potato
force-pushed
the
feat-move-experiment-calculator
branch
from
94f091f
to
246bab6
Compare
cre8ivejp
reviewed
Aug 5, 2024
|
|
||
| const ( | ||
| experimentLockPrefix = "experiment-calculate:" | ||
| experimentLockTTL = time.Minute |
There was a problem hiding this comment.
Depending on the number of events, it could take more than 1 minute to finish analyzing the data.
It will be safer if we set the default value to 10 minutes.
Also, can you make this configurable? It will be nice to pass the config via values.yaml.
cre8ivejp
reviewed
Aug 5, 2024
| ) | ||
|
|
||
| const ( | ||
| experimentLockPrefix = "experiment-calculate:" |
There was a problem hiding this comment.
Suggested change
| experimentLockPrefix = "experiment-calculate:" | |
| experimentLockKind = "experiment_lock" |
cre8ivejp
reviewed
Aug 5, 2024
| } | ||
|
|
||
| // getLockKey generates the lock key for a specific experiment | ||
| func (el *ExperimentLock) getLockKey(environmentID, experimentID string) string { |
There was a problem hiding this comment.
Suggested change
| func (el *ExperimentLock) getLockKey(environmentID, experimentID string) string { | |
| func (el *ExperimentLock) newLockKey(environmentID, experimentID string) string { |
|
|
||
| // getLockKey generates the lock key for a specific experiment | ||
| func (el *ExperimentLock) getLockKey(environmentID, experimentID string) string { | ||
| return fmt.Sprintf("%s%s:%s", experimentLockPrefix, environmentID, experimentID) |
There was a problem hiding this comment.
Suggested change
| return fmt.Sprintf("%s%s:%s", experimentLockPrefix, environmentID, experimentID) | |
| return fmt.Sprintf("%s:%s:%s", environmentID, experimentLockKind, experimentID) |
cre8ivejp
reviewed
Aug 5, 2024
| return el.lock.Unlock(ctx, lockKey, value) | ||
| } | ||
|
|
||
| // getLockKey generates the lock key for a specific experiment |
There was a problem hiding this comment.
Suggested change
| // getLockKey generates the lock key for a specific experiment | |
| // newLockKey generates the lock key for a specific experiment |
cre8ivejp
force-pushed
the
feat-move-experiment-calculator
branch
from
454c510
to
741f24e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will move experiment calculator to batch service.
Key Changes
This pull request includes several changes that focus on removing the
experiment-calculatorcomponent and adding a newhttpstanservice. The most important changes include the removal of the mainexperimentcalculator.gofile, updates to the Helm charts, and modifications to the dependencies in thego.modfile.Removal of
experiment-calculatorcomponent:cmd/experimentcalculator/experimentcalculator.go: Removed the entire file, including the main function and related imports.manifests/bucketeer/charts/experiment-calculator/Chart.yaml: Removed the Helm chart configuration for theexperiment-calculator.manifests/bucketeer/charts/experiment-calculator/templates/_helpers.tpl: Removed helper templates for theexperiment-calculator.manifests/bucketeer/charts/experiment-calculator/templates/deployment.yaml: Removed the deployment configuration for theexperiment-calculator.manifests/bucketeer/charts/experiment-calculator/templates/NOTES.txt: Removed the notes for theexperiment-calculatordeployment.manifests/bucketeer/charts/experiment-calculator/.helmignore: Removed the.helmignorefile for theexperiment-calculator.Addition of
httpstanservice:manifests/bucketeer/charts/batch/templates/deployment.yaml: Added configuration for the newhttpstanservice, including image details, ports, and health checks.manifests/bucketeer/charts/batch/values.yaml: Added values for thehttpstanservice, such as image repository, tag, port, and health path.Dependency updates:
go.mod: Addedgithub.com/google/uuid v1.6.0to the dependencies and removed it from the indirect dependencies. [1] [2]