Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsupported *.dartsearch.net rule #867

Closed
fmarier opened this issue May 27, 2022 · 0 comments
Closed

Remove unsupported *.dartsearch.net rule #867

fmarier opened this issue May 27, 2022 · 0 comments
Assignees

Comments

@fmarier
Copy link
Member

fmarier commented May 27, 2022

The *.dartsearch.net rule, introduced in #726 is using the wrong query string parameter (red which belongs to t.myvisualiq.com instead of ds_dest_url which belongs to dartsearch) because it attempts to do two debounces in one go.

Furthermore, clickserve.dartsearch.net actually requires brave/brave-browser#22429 to be implemented first because it doesn't encode its ds_dest_url in the way that the debouncer's redirect action expects it to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant