-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debouncing action to include all further URL parameters as part of the target URL #22429
Comments
Another test case from @fmarier:
|
Here's another one: The Zoom redirector incorrectly swallows the anchor in this one making it impossible to link to a section of a page within Zoom. |
This will be better handled by brave/brave-browser#22429.
This will be better handled by brave/brave-browser#22429.
Rules that can be re-added once this has landed: |
The AMP cache URLs that we would want to debounce: https://www-theverge-com.cdn.ampproject.org/c/s/www.theverge.com/platform/amp/2018/9/20/17881766/bing-google-amp-support-mobile-news They are all of the form: |
Thanks for the example @ShivanKaul . That would be another one for #22907 since that AMP URL doesn't have a query string. |
This one is tricky because it's actually the whole query string that must be extracted (no key to look for): |
One more: brave/adblock-lists#1025 |
The following URL was observed from a Google search page product ad placement when searching for
home depot tracking light
:https://clickserve.dartsearch.net/link/click?lid=92700067144412497&ds_s_kwgid=58700001236285396&ds_s_inventory_feed_id=97700000000001001&ds_a_cid=75683555&ds_a_caid=378324755&ds_a_agid=26777702795&ds_a_fiid=&ds_a_lid=pla-1457212127228&ds_a_extid=&&ds_e_adid=102712441595&ds_e_matchtype=search&ds_e_device=c&ds_e_network=g&ds_e_product_group_id=1457212127228&ds_e_product_id=202501682&ds_e_product_merchant_id=8740&ds_e_product_country=US&ds_e_product_language=en&ds_e_product_channel=online&ds_e_product_store_id=&ds_url_v=2&ds_dest_url=https://8808.xg4ken.com/trk/v1?prof=404&camp=19651&kct=google&kchid=7097773753&criteriaid=pla-1457212127228&campaignid=378324755&locphy=9061268&adgroupid=26777702795&adpos=&cid=102712441595&networkType=search&kdv=c&kext=&kadtype=pla&kmc=8740&kpid=202501682&url=https://www.homedepot.com/p/Lite-Line-8-ft-White-Track-Finished-HD-TR122/202501682?g_store=&source=shoppingads&locale=en-US&pla&mtc=Shopping-BF-F_Brand-G-Multi-NA-Multi-NA-Feed-PLA_LIA-NA-NA-Catchall_PLA&cm_mmc=Shopping-BF-F_Brand-G-Multi-NA-Multi-NA-Feed-PLA_LIA-NA-NA-Catchall_PLA-71700000014585962-58700001236285396-92700067144412497&gclsrc=aw.ds&gclid=EAIaIQobChMI3c322fag9wIVAcLCBB1ibwDvEAQYAyABEgJD3vD_BwE
This URL navigates through two levels of bounce tracking, first through
clickserve.dartsearch.net
, and then through itsds_dest_url
parameter to8808.xg4ken.com
, and then finally through itsurl
parameter towww.homedepot.com
.In order for Brave to properly debounce links like this, we need to use a debounce action that takes the entire rest of the URL after the relevant parameter, without any additional decoding, and redirects to it.
@pes10k has suggested calling this action
query-param+
, or implementing a general regex capability to be able to capture this along with additional cases.The text was updated successfully, but these errors were encountered: