Provide optional dependencies for qt instead of napari #84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
We were providing optional dependencies via
brainglobe-utils[napari]
. These includedqtpy
,superqt
, andnapari
itself. I realised that the actual code for the collapsible widgets (located in theqtpy
folder), doesn't actually make use ofnapari
, so that dependency was unnecessary.What does this PR do?
We instead provide
brainglobe-utils[qt]
, which includeqtpy
,superqt
as before, but NOTnapari
. This should also simplify dependency management in packages that rely on the collapsible widgets.References
I realised this while working on a napari widget for movement
How has this PR been tested?
Existing tests still pass (because napari was actually never even installed in the
dev
environment).Is this a breaking change?
In a way, packages that depended on collapsible widgets (
brainglobe-stitch
andbrainglobe-registration
?) need to update their dependencies tobrainglobe-utils[qt]
, and make sure to have a separatenapari
dependency. That's why I'm tagging @IgorTatarnikov as reviewer.Does this PR require an update to the documentation?
The README has been updated accordingly.
Checklist: