-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transform widget #88
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
==========================================
+ Coverage 91.59% 92.68% +1.08%
==========================================
Files 35 37 +2
Lines 1607 1845 +238
==========================================
+ Hits 1472 1710 +238
Misses 135 135
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adamltyson - looking good.
I made a few nitpicky comments that I think would help with legibility.
I opened an issue to address the cache issues separately #92
Closes #26. I decided to "brand" this widget as
brainmapper
as it essentially adds the missing functionality of brainmapper to napari.This also effectively reverses #84, as we now need napari.
I'm struggling to get the tests cache to work, so they're taking much longer than they should.
Docs and a tutorial need to be added, but I'm holding off doing this until this PR is merged, as the docs will depend on the final UI. Basic instructions are:
Once this is merged we should:
brainglobe-utils
brainglobe-utils
version in the metapackage