Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PressedButtons to PickingInteraction::Pressed. #16004

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mintlu8
Copy link
Contributor

@mintlu8 mintlu8 commented Oct 19, 2024

Objective

Fixes #15983. PickingInteraction is preferable to events in some use cases for code organization. This PR adds the keys pressed to PickingInteraction::Pressed, allowing the user to ignore certain keys like the RMB in such use cases.

Solution

  • Added field PressedButtons to PickingInteraction::Pressed.

Testing

  • Added a test for merging PickingInteractions.
  • Added an example for PickingInteraction.

Migration Guide

PickingInteraction::Pressed now has a field, code matching against it should use matches!(interaction, PickingInteraction::Pressed(..)) instead.

@IQuick143 IQuick143 added C-Feature A new feature, making something new possible D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward A-Picking Pointing at and selecting objects of all sorts labels Oct 19, 2024
@alice-i-cecile alice-i-cecile added this to the 0.16 milestone Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Picking Pointing at and selecting objects of all sorts C-Feature A new feature, making something new possible D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Picking: Filter keys in PickingInteraction
3 participants