Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sentry issue where sentry_dsn null string value should be converted to empty string #2883

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Fix sentry issue where sentry_dsn null string value should be converted to empty string #2883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion colin-api/src/colin_api/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@ class _Config: # pylint: disable=too-few-public-methods

SQLALCHEMY_TRACK_MODIFICATIONS = False

SENTRY_DSN = os.getenv('SENTRY_DSN', '')
SENTRY_DSN = os.getenv('SENTRY_DSN') or ''
SENTRY_DSN = '' if SENTRY_DSN.lower() == 'null' else SENTRY_DSN

LD_SDK_KEY = os.getenv('LD_SDK_KEY', None)

Expand Down
3 changes: 2 additions & 1 deletion jobs/email-reminder/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ class _Config(object): # pylint: disable=too-few-public-methods
PROJECT_ROOT = os.path.abspath(os.path.dirname(__file__))

SEND_OUTSTANDING_BCOMPS = os.getenv('SEND_OUTSTANDING_BCOMPS', None)
SENTRY_DSN = os.getenv('SENTRY_DSN', '')
SENTRY_DSN = os.getenv('SENTRY_DSN') or ''
SENTRY_DSN = '' if SENTRY_DSN.lower() == 'null' else SENTRY_DSN
LD_SDK_KEY = os.getenv('LD_SDK_KEY', None)

ACCOUNT_SVC_AUTH_URL = os.getenv('ACCOUNT_SVC_AUTH_URL', None)
Expand Down
3 changes: 2 additions & 1 deletion jobs/furnishings/src/furnishings/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ class _Config: # pylint: disable=too-few-public-methods

PROJECT_ROOT = os.path.abspath(os.path.dirname(__file__))

SENTRY_DSN = os.getenv('SENTRY_DSN', '')
SENTRY_DSN = os.getenv('SENTRY_DSN') or ''
SENTRY_DSN = '' if SENTRY_DSN.lower() == 'null' else SENTRY_DSN
LD_SDK_KEY = os.getenv('LD_SDK_KEY', None)

AUTH_URL = os.getenv('AUTH_URL', None)
Expand Down
3 changes: 2 additions & 1 deletion jobs/future-effective-filings/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@ class _Config(object): # pylint: disable=too-few-public-methods
AUTH_URL = os.getenv('AUTH_URL', '')
USERNAME = os.getenv('AUTH_USERNAME', '')
PASSWORD = os.getenv('AUTH_PASSWORD', '')
SENTRY_DSN = os.getenv('SENTRY_DSN', '')
SENTRY_DSN = os.getenv('SENTRY_DSN') or ''
SENTRY_DSN = '' if SENTRY_DSN.lower() == 'null' else SENTRY_DSN

SECRET_KEY = 'a secret'

Expand Down
3 changes: 2 additions & 1 deletion jobs/involuntary-dissolutions/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ class _Config(object): # pylint: disable=too-few-public-methods

PROJECT_ROOT = os.path.abspath(os.path.dirname(__file__))

SENTRY_DSN = os.getenv('SENTRY_DSN', '')
SENTRY_DSN = os.getenv('SENTRY_DSN') or ''
SENTRY_DSN = '' if SENTRY_DSN.lower() == 'null' else SENTRY_DSN
LD_SDK_KEY = os.getenv('LD_SDK_KEY', None)

NATS_SERVERS = os.getenv('NATS_SERVERS', None)
Expand Down
3 changes: 2 additions & 1 deletion jobs/update-colin-filings/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ class _Config(object): # pylint: disable=too-few-public-methods

COLIN_URL = os.getenv('COLIN_URL', '')
LEGAL_API_URL = os.getenv('LEGAL_API_URL', '')
SENTRY_DSN = os.getenv('SENTRY_DSN', '')
SENTRY_DSN = os.getenv('SENTRY_DSN') or ''
SENTRY_DSN = '' if SENTRY_DSN.lower() == 'null' else SENTRY_DSN

ACCOUNT_SVC_AUTH_URL = os.getenv('ACCOUNT_SVC_AUTH_URL', None)
ACCOUNT_SVC_CLIENT_ID = os.getenv('ACCOUNT_SVC_CLIENT_ID', None)
Expand Down
3 changes: 2 additions & 1 deletion jobs/update-legal-filings/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ class _Config(object): # pylint: disable=too-few-public-methods

COLIN_URL = os.getenv('COLIN_URL', '')
LEGAL_API_URL = os.getenv('LEGAL_API_URL', '')
SENTRY_DSN = os.getenv('SENTRY_DSN', '')
SENTRY_DSN = os.getenv('SENTRY_DSN') or ''
SENTRY_DSN = '' if SENTRY_DSN.lower() == 'null' else SENTRY_DSN

ACCOUNT_SVC_AUTH_URL = os.getenv('ACCOUNT_SVC_AUTH_URL', None)
ACCOUNT_SVC_CLIENT_ID = os.getenv('ACCOUNT_SVC_CLIENT_ID', None)
Expand Down
5 changes: 3 additions & 2 deletions queue_services/business-pay/src/business_pay/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,8 @@ class Config: # pylint: disable=too-few-public-methods

PAYMENT_SVC_URL = os.getenv("PAYMENT_SVC_URL", "")

SENTRY_DSN = os.getenv("SENTRY_DSN", None)
SENTRY_DSN = os.getenv('SENTRY_DSN') or ''
SENTRY_DSN = '' if SENTRY_DSN.lower() == 'null' else SENTRY_DSN

SQLALCHEMY_TRACK_MODIFICATIONS = False

Expand Down Expand Up @@ -142,7 +143,7 @@ class Config: # pylint: disable=too-few-public-methods
)
SUB_AUDIENCE = os.getenv("SUB_AUDIENCE", "")
SUB_SERVICE_ACCOUNT = os.getenv("SUB_SERVICE_ACCOUNT", "")

SBC_CONNECT_GCP_QUEUE_DEBUG = os.getenv("SBC_CONNECT_GCP_QUEUE_DEBUG", "")

NATS_CONNECT_ERROR_COUNT_MAX = os.getenv("NATS_CONNECT_ERROR_COUNT_MAX", 10)
Expand Down
3 changes: 2 additions & 1 deletion queue_services/entity-bn/src/entity_bn/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ class _Config(): # pylint: disable=too-few-public-methods

PROJECT_ROOT = os.path.abspath(os.path.dirname(__file__))

SENTRY_DSN = os.getenv('SENTRY_DSN', None)
SENTRY_DSN = os.getenv('SENTRY_DSN') or ''
SENTRY_DSN = '' if SENTRY_DSN.lower() == 'null' else SENTRY_DSN
COLIN_API = f"{os.getenv('COLIN_API_URL', '')}{os.getenv('COLIN_API_VERSION', '')}"

SEARCH_API = \
Expand Down
3 changes: 2 additions & 1 deletion queue_services/entity-digital-credentials/src/entity_digital_credentials/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ class _Config(): # pylint: disable=too-few-public-methods

PROJECT_ROOT = os.path.abspath(os.path.dirname(__file__))

SENTRY_DSN = os.getenv('SENTRY_DSN', None)
SENTRY_DSN = os.getenv('SENTRY_DSN') or ''
SENTRY_DSN = '' if SENTRY_DSN.lower() == 'null' else SENTRY_DSN
LD_SDK_KEY = os.getenv('LD_SDK_KEY', None)

# variables
Expand Down
2 changes: 2 additions & 0 deletions queue_services/entity-emailer/src/entity_emailer/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ class _Config(): # pylint: disable=too-few-public-methods

MSG_RETRY_NUM = int(os.getenv('MSG_RETRY_NUM', '5'))

SENTRY_DSN = os.getenv('SENTRY_DSN') or ''
SENTRY_DSN = '' if SENTRY_DSN.lower() == 'null' else SENTRY_DSN
LD_SDK_KEY = os.getenv('LD_SDK_KEY', None)

# urls
Expand Down
3 changes: 2 additions & 1 deletion queue_services/entity-filer/src/entity_filer/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@ class _Config(): # pylint: disable=too-few-public-methods

PAYMENT_SVC_URL = os.getenv('PAYMENT_SVC_URL', '')

SENTRY_DSN = os.getenv('SENTRY_DSN', None)
SENTRY_DSN = os.getenv('SENTRY_DSN') or ''
SENTRY_DSN = '' if SENTRY_DSN.lower() == 'null' else SENTRY_DSN

SQLALCHEMY_TRACK_MODIFICATIONS = False

Expand Down
3 changes: 2 additions & 1 deletion queue_services/entity-pay/src/entity_pay/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@ class _Config(): # pylint: disable=too-few-public-methods

PAYMENT_SVC_URL = os.getenv('PAYMENT_SVC_URL', '')

SENTRY_DSN = os.getenv('SENTRY_DSN', None)
SENTRY_DSN = os.getenv('SENTRY_DSN') or ''
SENTRY_DSN = '' if SENTRY_DSN.lower() == 'null' else SENTRY_DSN

SQLALCHEMY_TRACK_MODIFICATIONS = False

Expand Down
Loading