Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sentry issue where sentry_dsn null string value should be converted to empty string #2883

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

argush3
Copy link
Collaborator

@argush3 argush3 commented Jul 31, 2024

Issue #: /bcgov/entity###

Description of changes:

  • Fix sentry_dsn config issue where null value is populated in OCP secrets when sentry_dsn is populated with empty string in 1pass. We need to initialize sentry with empty string in this case.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@argush3 argush3 self-assigned this Jul 31, 2024
Copy link

sonarcloud bot commented Jul 31, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
30.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@argush3 argush3 merged commit 4327946 into bcgov:main Jul 31, 2024
39 of 49 checks passed
@argush3 argush3 deleted the sentry_fix_remaining_be_services branch July 31, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants