Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SNAP FORK][UPSTREAMED] remove linux constraint #59

Open
wants to merge 1 commit into
base: pre-alpha
Choose a base branch
from
Open

[SNAP FORK][UPSTREAMED] remove linux constraint #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion toolchains/android_sdk/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ toolchain(
name = "android_sdk_tools",
exec_compatible_with = [
"@platforms//cpu:x86_64",
"@platforms//os:linux",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Mauricio,

I'm assuming the answer if yes, but have you verified this works on x86 + Mac on your end? We don't have non-Linux x86 CI jobs set up yet for rules_android, so we have no way of guarding against regressions for the time being.

Copy link
Contributor

@nkoroste nkoroste Apr 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, we're using this on Mac x86, Mac M1 and Mac M2. I will let Mauricio to confirm though

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this works for us

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! TBH I am a little surprised that this actually just works, since the various SDK binaries differ between the Linux and Mac versions, but maybe the toolchain selection for the individual tools just occurs somewhere else.

],
# TODO(b/175833893): This causes the toolchain to not be selected, so
# disable for now.
Expand Down