[SNAP FORK][UPSTREAMED] remove linux constraint #59
Conversation
Remove the linux constrains in order to make sdk compatible with macos
| @@ -18,7 +18,6 @@ toolchain( | |||
| name = "android_sdk_tools", | |||
| exec_compatible_with = [ | |||
| "@platforms//cpu:x86_64", | |||
| "@platforms//os:linux", | |||
There was a problem hiding this comment.
Hi Mauricio,
I'm assuming the answer if yes, but have you verified this works on x86 + Mac on your end? We don't have non-Linux x86 CI jobs set up yet for rules_android, so we have no way of guarding against regressions for the time being.
There was a problem hiding this comment.
Yea, we're using this on Mac x86, Mac M1 and Mac M2. I will let Mauricio to confirm though
There was a problem hiding this comment.
Yeah this works for us
There was a problem hiding this comment.
Cool! TBH I am a little surprised that this actually just works, since the various SDK binaries differ between the Linux and Mac versions, but maybe the toolchain selection for the individual tools just occurs somewhere else.
|
Actuallty, it looks like this was already superceded #60. @mauriciogg can you confirm that #60 accomplishes the same thing that this PR set to do? If yes, we can close this PR as obsolete. |
Bazel 7.0 still contains the native version of android_ndk_repository
Remove the linux constrains in order to make sdk compatible with macos