chore: deflake metrics test #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeDombo
reviewed
Feb 5, 2024
| //Wait for the emitter to run | ||
| Mockito.verify(metricSpy, Mockito.timeout(2000L).atLeastOnce()).emitMetrics(); | ||
| AtomicReference<List<Metric>> results = new AtomicReference<>(); | ||
| eventuallyTrue(() -> { |
There was a problem hiding this comment.
you need to assert on this eventually true
MikeDombo
reviewed
Feb 5, 2024
| ResultCaptor<List<Metric>> resultMetrics = new ResultCaptor<>(); | ||
| doAnswer(resultMetrics).when(metricSpy).collectMetrics(); | ||
|
|
||
| //Wait for the emitter to run | ||
| Mockito.verify(metricSpy, Mockito.timeout(2000L).atLeastOnce()).emitMetrics(); |
There was a problem hiding this comment.
keeping the mockito verify should be used instead of eventually true. Was it the reset which was clearing things out?
There was a problem hiding this comment.
yeah was thinking it's a race between setting up the mock and performing the ipc call. removed the eventually true and just re-ordered things
|
Code Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against 6b480ba |
jcosentino11
force-pushed
the
deflake-metrics-test
branch
from
d184047
to
6b480ba
Compare
Benchmark Results
|
MikeDombo
approved these changes
Feb 5, 2024
sameerzuberi
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Attempt to get rid of null pointers showing up in recent test runs for
GIVEN_kernelRunningWithMetricsConfig_WHEN_verifyClientDeviceIdentity_THEN_successMetricEmittedWhy is this change necessary:
How was this change tested:
Any additional information or context required to review the change:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.