-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: deflake rest of MetricsEmitterTest #421
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcosentino11
changed the title
chore: deflake rest of test
chore: deflake rest of MetricsEmitterTest
Feb 5, 2024
MikeDombo
approved these changes
Feb 5, 2024
Code Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against c71327f |
Benchmark Results
|
robcmann
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Continuation of #420, extended to the whole
MetricsEmitterTest
.Previously we waited for
emitMetrics
to be called to signal a metric was reported, but even with #420 there is still a race between calling the API andemitMetrics
(GIVEN_kernelRunningWithMetricsConfig_WHEN_subscribeToCertificateUpdate_THEN_successMetricEmitted, for example was failing unit tests when attempting to make the same change).To ignore the race, we can capture the first (non empty) list of metrics, and wait for metric emitter to run at least another cycle and verify no extra methods are emitted. This would verify that for one API call, we get exactly one metric emit.
Why is this change necessary:
How was this change tested:
Any additional information or context required to review the change:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.