-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(storage-browser): add e2e test for offline Create folder action #5759
Open
hbuchel
wants to merge
23
commits into
feat-storage-browser/main
Choose a base branch
from
feat-storage-browser/create-folder-e2e
base: feat-storage-browser/main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
f63a675
chore(storage-browser): set up e2e tests for storage browser
timngyn d712b0a
remove unused variable
timngyn 1bd1f93
remove unused var
timngyn 867df3e
Merge branch 'feat-storage-browser/main' into feat-storage-browser/e2…
timngyn 83fdc3b
add e2e tests for create folder
timngyn a93eb9e
add e2e tests for navigate control
timngyn 0d80349
remove render-storage-browser.feature
timngyn 5c4bcee
add e2e tests for download file
timngyn c96c5a9
Merge branch 'feat-storage-browser/main' into feat-storage-browser/e2…
jordanvn e583231
chore: add tests for 403 response and error boundary to forbidden act…
jordanvn 143cc08
chore: making more generic references to button contents
jordanvn 050ea17
chore: temporarily removing status code validation prior to cleaner a…
jordanvn 7c0287e
chore: restoring resolution to unauthed tests with cleaner solution
jordanvn 5ebdece
Merge branch 'feat-storage-browser/main' into feat-storage-browser/e2…
jordanvn 18c3d4c
chore: removing file download test for now to ensure passing pipeline…
jordanvn f4daeb2
chore: add newline charactersd
jordanvn b72bfef
chore: adding additional newline character
jordanvn 9bd0047
Merge branch 'feat-storage-browser/main' into feat-storage-browser/e2…
hbuchel f78ea18
Merge branch 'feat-storage-browser/main' into feat-storage-browser/e2…
hbuchel e132e3c
add offline Create Folder e2e test
hbuchel 4298f4d
add new line
hbuchel 983d068
merge latest
hbuchel d196e6d
remove file leftover before merge
hbuchel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
12 changes: 12 additions & 0 deletions
12
...ss/integration/ui/components/storage/storage-browser/create-folder/create-folder.steps.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
import { When } from '@badeball/cypress-cucumber-preprocessor'; | ||
import { escapeRegExp } from 'lodash'; | ||
|
||
When('I click the "Create Folder" button while offline', () => { | ||
cy.intercept('', (req) => { | ||
req.destroy(); | ||
}); | ||
|
||
cy.findByRole('button', { | ||
name: new RegExp(`^${escapeRegExp('Create Folder')}$`, 'i'), | ||
}).click(); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -145,7 +145,7 @@ describe('LocationDetailView', () => { | |
hasError: true, | ||
message: errorMessage, | ||
result: [{ key: 'test1', type: 'FOLDER' }], | ||
nextToken: 'some-token' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Prettier change, though I'm not sure why it wasn't already there. |
||
nextToken: 'some-token', | ||
}); | ||
|
||
render( | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prettier change, though I'm not sure why it wasn't already there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been getting this a lot, there seems to be some non-deterministic behavior with our prettier setup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure your VSCode (not you personally, but all of us) is using the project's version of prettier and not a globally installed one