Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storage-browser): add e2e test for offline Create folder action #5759

Open
wants to merge 23 commits into
base: feat-storage-browser/main
Choose a base branch
from

Conversation

hbuchel
Copy link
Contributor

@hbuchel hbuchel commented Sep 6, 2024

Description of changes

  • Adds an e2e test for Create folder to verify that it shows a network error if folder creation is attempted while offline.
  • There are two files that just have a small prettier change each.
Screenshot 2024-09-06 at 12 30 53 PM

Issue #, if available

Description of how you validated changes

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • yarn test passes and tests are updated/added
  • PR title and commit messages follow conventional commit syntax
  • If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

changeset-bot bot commented Sep 6, 2024

⚠️ No Changeset found

Latest commit: d196e6d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hbuchel hbuchel changed the base branch from feat-storage-browser/main to feat-storage-browser/e2e-storage-browser September 6, 2024 16:38
Base automatically changed from feat-storage-browser/e2e-storage-browser to feat-storage-browser/main September 9, 2024 20:20
@hbuchel hbuchel marked this pull request as ready for review October 11, 2024 16:02
@hbuchel hbuchel requested a review from a team as a code owner October 11, 2024 16:02
@@ -78,7 +78,9 @@ export const LocationDetailViewControls = (): React.JSX.Element => {
const [state] = useControl('NAVIGATE');
const { path } = state;

const [{ data, isLoading, hasError }, handleList] = useAction('LIST_LOCATION_ITEMS');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier change, though I'm not sure why it wasn't already there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been getting this a lot, there seems to be some non-deterministic behavior with our prettier setup

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure your VSCode (not you personally, but all of us) is using the project's version of prettier and not a globally installed one

@@ -145,7 +145,7 @@ describe('LocationDetailView', () => {
hasError: true,
message: errorMessage,
result: [{ key: 'test1', type: 'FOLDER' }],
nextToken: 'some-token'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier change, though I'm not sure why it wasn't already there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants