-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(storage-browser): add e2e test for offline Create folder action #5759
base: feat-storage-browser/main
Are you sure you want to change the base?
chore(storage-browser): add e2e test for offline Create folder action #5759
Conversation
…e-storage-browser
…e-storage-browser
…e-storage-browser
… in first set of tests
…e-storage-browser
…e-storage-browser
|
@@ -78,7 +78,9 @@ export const LocationDetailViewControls = (): React.JSX.Element => { | |||
const [state] = useControl('NAVIGATE'); | |||
const { path } = state; | |||
|
|||
const [{ data, isLoading, hasError }, handleList] = useAction('LIST_LOCATION_ITEMS'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prettier change, though I'm not sure why it wasn't already there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been getting this a lot, there seems to be some non-deterministic behavior with our prettier setup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure your VSCode (not you personally, but all of us) is using the project's version of prettier and not a globally installed one
@@ -145,7 +145,7 @@ describe('LocationDetailView', () => { | |||
hasError: true, | |||
message: errorMessage, | |||
result: [{ key: 'test1', type: 'FOLDER' }], | |||
nextToken: 'some-token' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prettier change, though I'm not sure why it wasn't already there.
Description of changes
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passes and tests are updated/addeddocs
,e2e
,examples
, or other private packages.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.