New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delegation PoC #504

Merged

cam-schultz merged 41 commits into staking-contract from delegation-poc

Sep 5, 2024

+3,538 −149

Merged

Delegation PoC #504

Update contracts/staking/NativeTokenStakingManager.sol

GitHub Advanced Security / Slither succeeded Sep 5, 2024 in 4s

2 new alerts including 2 low severity security vulnerabilities

New alerts in code changed by this pull request

Security Alerts:

2 low

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 278 in contracts/staking/PoSValidatorManager.sol

Code scanning / Slither

Reentrancy vulnerabilities Low

Reentrancy in PoSValidatorManager.initializeEndDelegation(bytes32):
External calls:
- messageID = WARP_MESSENGER.sendWarpMessage(setValidatorWeightPayload)
Event emitted after the call(s):
- DelegatorRemovalInitialized({validationID:validationID,setWeightMessageID:messageID,delegator:_msgSender(),validatorWeight:validator.weight,nonce:nonce,endTime:block.timestamp})

Check notice on line 350 in contracts/staking/ValidatorManager.sol

Code scanning / Slither

Block timestamp Low

ValidatorManager._checkAndUpdateChurnTracker(uint64) uses timestamp for comparisons
Dangerous comparisons:
- currentTime - churnTracker.startedAt >= 3600
- require(bool,string)(churnPercentage <= $._maximumHourlyChurn,ValidatorManager: maximum hourly churn rate exceeded)