-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(lane_change): refactor longitudinal acceleration sampling #9091
base: main
Are you sure you want to change the base?
refactor(lane_change): refactor longitudinal acceleration sampling #9091
Conversation
Signed-off-by: mohammad alqudah <[email protected]>
Signed-off-by: mohammad alqudah <[email protected]>
Signed-off-by: mohammad alqudah <[email protected]>
Signed-off-by: mohammad alqudah <[email protected]>
Signed-off-by: mohammad alqudah <[email protected]>
…on-when-nearing-terminal Signed-off-by: mohammad alqudah <[email protected]>
Signed-off-by: mohammad alqudah <[email protected]>
…on-when-nearing-terminal
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9091 +/- ##
==========================================
- Coverage 28.26% 27.85% -0.41%
==========================================
Files 1306 1303 -3
Lines 101091 95780 -5311
Branches 39243 39015 -228
==========================================
- Hits 28573 26683 -1890
+ Misses 69761 66340 -3421
Partials 2757 2757
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
...ng/behavior_path_planner/autoware_behavior_path_lane_change_module/src/utils/calculation.cpp
Outdated
Show resolved
Hide resolved
planning/behavior_path_planner/autoware_behavior_path_lane_change_module/src/scene.cpp
Show resolved
Hide resolved
...ng/behavior_path_planner/autoware_behavior_path_lane_change_module/src/utils/calculation.cpp
Outdated
Show resolved
Hide resolved
...ng/behavior_path_planner/autoware_behavior_path_lane_change_module/src/utils/calculation.cpp
Show resolved
Hide resolved
planning/behavior_path_planner/autoware_behavior_path_lane_change_module/src/scene.cpp
Outdated
Show resolved
Hide resolved
…on-when-nearing-terminal Signed-off-by: mohammad alqudah <[email protected]>
Signed-off-by: mohammad alqudah <[email protected]>
Description
when sampling lane change paths, the min & max longitudinal accelerations are computed once using the maximum prepare duration setting. The longitudinal acceleration is then sampled between the computed min & max values, and used to generated prepare phase metrics.
However when ego is approaching terminal, the prepare duration will also be sampled between 0 and max prepare duration, in that case the min & max longitudinal acceleration values computed previously can be invalid for prepare duration lower than max prepare duration, and can result in failure to generate LC path.
Therefore, it is more logical to compute min & max longitudinal accelerations and sample it for each prepare duration separately.
Changes
calculation.cpp
calc_prepare_phase_metrics
to sample lon acceleration for each prepare duration separatelyRelated links
None.
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.