fix(control): missing dependency in control components #9073
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f0reachARR
requested review from
TakaHoribe,
tkimura4,
takayuki5168,
kyoichi-sugahara,
mkuri,
soblin and
danielsanchezaran
as code owners
github-actions
bot
added
the
component:control
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
f0reachARR
changed the title
HansRobo
added
the
tag:run-build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9073 +/- ##
=======================================
Coverage 26.95% 26.95%
=======================================
Files 1297 1300 +3
Lines 95780 95811 +31
Branches 39136 39137 +1
=======================================
+ Hits 25820 25830 +10
- Misses 67370 67390 +20
- Partials 2590 2591 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Could you review this PR? |
soblin
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add / modify dependencies written in package.xml.
The changed dependencies are almost about ament_index_cpp.
Jazzy has a build error due to not having a dependency on ament_index_cpp.
We have found similar errors in other ROS packages and have confirmed that they are not specific to the author's environment.
Related links
Reference: #7598
Base pull request: #7600
How was this PR tested?
colcon test passed.
This PR does not change the behavior of Autoware.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.