Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ltp: sigprocmask fix #9923

Merged
merged 1 commit into from
Aug 1, 2023
Merged

ltp: sigprocmask fix #9923

merged 1 commit into from
Aug 1, 2023

Conversation

zzby0
Copy link

@zzby0 zzby0 commented Jul 28, 2023

Summary

problem: SIGKILL and SIGSTOP should not be added in signal mask;
solution: check before adding signal to signal mask

Impact

ostest: sigprocmask (under /apps/testing/ostest) will fail, so I change ostest: sigprocmask.c together

Testing

@zzby0
Copy link
Author

zzby0 commented Jul 28, 2023

ostest change commit is here: apache/nuttx-apps#1857

sched/signal/sig_procmask.c Outdated Show resolved Hide resolved
sched/signal/sig_procmask.c Show resolved Hide resolved
@zzby0 zzby0 marked this pull request as draft July 30, 2023 08:29
1. change signal/sig_procmask.c and pthread/pthread_sigmask.c together
2. clear signals unconditionally

Signed-off-by: guanyi <[email protected]>
@zzby0 zzby0 marked this pull request as ready for review August 1, 2023 02:11
@xiaoxiang781216 xiaoxiang781216 merged commit 55a727b into apache:master Aug 1, 2023
26 checks passed
@masayuki2009
Copy link
Contributor

@zzby0 @xiaoxiang781216

I noticed that ostest failed with spresense:smp since the apache/nuttx-apps#1857 is not merged.

receiver_thread: returning nerrors=0
timedmqueue_test: Test complete

End of test memory usage:
VARIABLE  BEFORE   AFT[CPU0] _assert: Current Version: NuttX  12.0.0 55a727b1ce Aug  1 2023 15:05:49 arm
[CPU0] _assert: Assertion failed : at file: :0 task(CPU0): ostest 0xd00d509
[CPU0] up_dump_register: R0: 2d029030 R1: 00000000 R2: 00000000  R3: 2d028b90
[CPU0] up_dump_register: R4: 2d029030 R5: 2d02ec18 R6: 0d020058  FP: 00000000
[CPU0] up_dump_register: R8: 00000000 SB: 00000000 SL: 00000000 R11: 00000000
[CPU0] up_dump_register: IP: 00000001 SP: 2d0335e0 LR: 0d003e0d  PC: 0d003e0d
[CPU0] up_dump_register: xPSR: 60000000 BASEPRI: 000000e0 CONTROL: 00000004
[CPU0] up_dump_register: EXC_RETURN: ffffffff
[CPU0] dump_stack: User Stack:
[CPU0] dump_stack:   base: 0x2d031778
[CPU0] dump_stack:   size: 00008128
[CPU0] dump_stack:     sp: 0x2d0335e0
[CPU0] stack_dump: 0x2d0335e0: 0d026533 00000000 00000000 2d02eca0 0d00d509 0d004e3d 00000000 7474754e
[CPU0] stack_dump: 0x2d033600: 2d020058 0d004e79 00000000 2d02ec18 000000e0 2d02ee87 00000001 0d003b85
[CPU0] stack_dump: 0x2d033620: 2d0272c8 000000e0 0000002f 0d004d61 2e323100 00302e30 0000002f 0d004d7d
[CPU0] stack_dump: 0x2d033640: 00000000 35354e3d 37323761 65633162 67754120 20312020 33323032 3a353120
[CPU0] stack_dump: 0x2d033660: 343a3530 2d030039 0d02006c 0d003b85 2d02ee30 000000e0 6d726158 0d004d00
[CPU0] stack_dump: 0x2d033680: 2d02ee30 2d02ee2c 0d020058 0d004d7d 2d02ee30 00000005 00000009 0d020058
[CPU0] stack_dump: 0x2d0336a0: 2d031740 0d02006c 2d03176e 00000000 00000000 0d008197 00000000 0d00eaf5
[CPU0] stack_dump: 0x2d0336c0: 00000000 00000000 000000aa 00000000 000002aa 00000000 00000005 00000000
[CPU0] stack_dump: 0x2d0336e0: 2d02984c 2d031740 0d01f577 0d00d6f5 00155470 00000003 00000066 0014c8c0
[CPU0] stack_dump: 0x2d033700: 00006da8 0014e6c8 00000000 0d00d509 00000005 2d031740 00000000 00000000
ER
======== ======== ========
arena      155470   155470
ordblks         4        5
mxordblk   14a8b8   1488b0
uordblks     8548     a640
fordblks   14cf28   14ae30

user_main: sigprocmask test
sigprocmask_test: ERROR unexpected sigprocmask
ostest_main: Exiting with status 256

@xiaoxiang781216
Copy link
Contributor

Yes, ostest need update too, let me merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants