Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ostest: sigprocmask testcase fix #1857

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Conversation

zzby0
Copy link

@zzby0 zzby0 commented Jul 28, 2023

Summary

fix ostest sigprocmask testcase
problem: signal "SIGSTOP" and "SIGKILL" shouldn't be in sigprocmask

Impact

Testing

@zzby0
Copy link
Author

zzby0 commented Jul 28, 2023

I change sched/signal/sig_procmask.c together, commit is here: apache/nuttx#9923

@xiaoxiang781216
Copy link
Contributor

@zzby0 please remove Gerrit Change-ID's before submitting upstream

@zzby0 zzby0 marked this pull request as draft July 30, 2023 08:29
@zzby0 zzby0 marked this pull request as ready for review August 1, 2023 01:58
Copy link
Contributor

@jerpelea jerpelea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a commit message describing the change

problem: ostest may fail at procmask test, because signals:sigkill/sigstop should not be added in signal mask
solution: skip checking whether sigkill/sigstop are in signal mask

Signed-off-by: guanyi <[email protected]>
@masayuki2009 masayuki2009 merged commit f50d2cd into apache:master Aug 1, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants