-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libxx: Map all output files to the bin directory #14657
Conversation
[Experimental Bot, please feedback here] No, this PR does not meet the NuttX requirements. While it provides a summary, it lacks crucial information. Here's why:
To make this PR acceptable, the author needs to:
Without these improvements, the PR provides insufficient information for proper review and cannot be considered complete. |
07039cb
to
b0f176e
Compare
8c1f44d
to
06b15cc
Compare
1. There are files with the same name in libcxx, so the generated files must be separated by files Signed-off-by: wangmingrong1 <[email protected]>
@@ -37,6 +37,11 @@ libcxx: libcxx-$(LIBCXX_VERSION).src.tar.xz | |||
$(Q) patch -p0 < 0001-libcxx-fix-ld-errors.patch | |||
$(Q) patch -p0 < 0001-Fix-build-error-about-__GLIBC__.patch | |||
$(Q) touch $@ | |||
$(Q) mkdir $(BINDIR)/libcxx \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why need manually create the subdir?
Through discussion, since the bin directory is mainly for separate compilation of kernel mode and user mode, libxx does not need this process. Therefore, the creation of the bin directory is meaningless and this patch will be closed. |
Summary
libxx: Map all output files to the bin directory
Impact
No
Testing
Mo