-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libxx: All cxx libraries move down one level #14668
base: master
Are you sure you want to change the base?
Conversation
[Experimental Bot, please feedback here] No. This PR does not adequately meet the NuttX requirements. While it provides a brief summary, it lacks crucial details. Here's why:
In short, the PR needs to be significantly more detailed and self-contained to meet the NuttX requirements. It should clearly explain the motivation, implementation details, potential impact, and provide independent verification of its functionality. |
4bb2673
to
235d793
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but please include an explanatory message in the commit log as to why this was necessary?
OKey |
Sorry I have to cancel the CI Check, there's a problem with CI Test: |
Do we need to restart ci after the fix is merged? |
@W-M-R Hopefully not? Let us track down the root cause and figure out the impact. Thanks! |
610bd67
to
2c79bda
Compare
Since there are some patches that need to be loaded manually, the original method is rather confusing. Now these patches that need to be loaded manually are classified into various cxx library folders, and each dynamically downloaded cxx library is moved down one directory to make the directory structure clearer. Signed-off-by: wangmingrong1 <[email protected]>
Sorry I cancelled the CI Check again, since there's a problem with CI Test: |
Note: Please adhere to Contributing Guidelines.
Summary
Since there are some patches that need to be loaded manually, the original method is rather confusing. Now these patches that need to be loaded manually are classified into various cxx library folders, and each dynamically downloaded cxx library is moved down one directory to make the directory structure clearer.
Impact
No
Testing
No