board/arm/nrf52: fix use up_interrupt_context to is_nesting_interrupt #13895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: Board support
1 task
anchao
requested changes
Oct 8, 2024
jasonbu
changed the title
anchao
approved these changes
Oct 8, 2024
|
this PR fixes #13831 |
The case want to determine if a interrupt with higher priority and the interrupt preemption occurred, but up_interrupt_context indicates that we self inside interrupt/handler mode. As we previously did not handle the ramvector interrupt correctly, after update breaked the case. We should use a more clear private function is_nesting_interrupt. Signed-off-by: buxiasen <[email protected]>
up_interrupt_context indicates that we self inside interrupt/handler mode, replaced to private function is_nesting_interrupt to make less confused. Signed-off-by: buxiasen <[email protected]>
github-actions
bot
added
Size: S
GUIDINGLI
approved these changes
Oct 8, 2024
append a commit in this patch, please review, |
1 task
raiden00pl
approved these changes
Oct 8, 2024
xiaoxiang781216
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The case want to determine if a interrupt with higher priority the interrupt preemption occurred,
but up_interrupt_context indicates that we self inside interrupt/handedr mode.
As we previously did not handle the ramvector interrupt correctly, after update breaked the case.
We should use a more clear private function is_nesting_interrupt.
#13831
Impact
No impact as we only changed the case in nrf52_highpri.
Maybe further patch should keep the api up_current_regs.
Testing
CI-test