Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] highpri examples are broken #13831

Closed
1 task done
raiden00pl opened this issue Oct 5, 2024 · 4 comments · Fixed by #13895
Closed
1 task done

[BUG] highpri examples are broken #13831

raiden00pl opened this issue Oct 5, 2024 · 4 comments · Fixed by #13895
Assignees
Labels
Arch: arm Issues related to ARM (32-bit) architecture Area: Kernel Kernel issues blocker Release Blocker

Comments

@raiden00pl
Copy link
Contributor

raiden00pl commented Oct 5, 2024

Description / Steps to reproduce the issue

Tested with nrf52840-dk/highpri but probably all examples of highpri are broken.

./tools/configure.sh nrf52840-dk/highpri 
make -j

output on 12.7-RC:

Elapsed time: 160 seconds

  basepri[80]: 920 (1%)
  basepri[e0]: 78764 (99%)
  Handler:     79684 (100%)
  Thread:      0 (0%)

The correct output should be like this:

Elapsed time: 160 seconds

  basepri[80]: 920 (1%)
  basepri[e0]: 78767 (99%)
  Handler:     44 (0%)
  Thread:      79643 (100%)

Broken with 0561b55
After this commit we have lose the ability to distinguish in the highpri handler if we are in thread or interrupt context.

When we revert this commit, highpri examples works again:

Elapsed time: 160 seconds

  basepri[80]: 459 (1%)
  basepri[e0]: 39383 (99%)
  Handler:     22 (0%)
  Thread:      39820 (100%)

ping @hujun260 @xiaoxiang781216

On which OS does this issue occur?

[OS: Linux]

What is the version of your OS?

Arch Linux

NuttX Version

nuttx-12.7.0-RC0, master

Issue Architecture

[Arch: arm]

Issue Area

[Area: Kernel]

Verification

  • I have verified before submitting the report.
@raiden00pl raiden00pl added the blocker Release Blocker label Oct 5, 2024
@github-actions github-actions bot added Arch: arm Issues related to ARM (32-bit) architecture Area: Kernel Kernel issues labels Oct 5, 2024
@xiaoxiang781216
Copy link
Contributor

@GUIDINGLI

@xiaoxiang781216
Copy link
Contributor

@raiden00pl could you try #13606?

@jasonbu
Copy link
Contributor

jasonbu commented Oct 8, 2024

hi, please review the patch #13895

The case want to determine if a interrupt with higher priority and the interrupt preemption occurred,
but up_interrupt_context indicates that we self inside interrupt/handler mode.

so this should be usage problem, and we should update the case, and make it less confused.

@jerpelea
Copy link
Contributor

backport #14395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arch: arm Issues related to ARM (32-bit) architecture Area: Kernel Kernel issues blocker Release Blocker
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants