Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In its current state the R grammar is hard to use, since there is one parser rule containing almost everything. Additionally, most tokens are defined implicitly. Therefore the AST elements that are generated can only be distinguished by comparing the strings in the tokens. That requires a lot of hard-coded string literals in the application code.
To make using the AST easier, this PR defines most tokens explicitly and breaks up the parser rules into smaller ones. I tried to do that as general as possible, but I focused on what is needed for JPlag.
With these changes the AST nodes can be distinguished by their types. Different cases can be checked via the names of the tokens instead of using a string comparison.
Terminal nodes can be identified through named constants.
As far as I can tell the functionality of the grammar has not changed. I would appreciate it if someone could confirm that.
This PR is a follow up to #4160.