-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored RLang language module to new framework #1864
Open
TwoOfTwelve
wants to merge
3
commits into
develop
Choose a base branch
from
feature/refactorRLang
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsaglam
added
enhancement
Issue/PR that involves features, improvements and other changes
major
Major issue/feature/contribution/change
language
PR / Issue deals (partly) with new and/or existing languages for JPlag
labels
Jul 11, 2024
Quality Gate passed for 'JPlag Plagiarism Detector'Issues Measures |
Kr0nox
requested changes
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some things to discuss in the meeting
Kr0nox
approved these changes
Sep 12, 2024
tsaglam
approved these changes
Sep 13, 2024
@TwoOfTwelve only the conflicts are left. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Issue/PR that involves features, improvements and other changes
language
PR / Issue deals (partly) with new and/or existing languages for JPlag
major
Major issue/feature/contribution/change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored the code for the rlang language module for the new framework. In doing so I noticed that the ANTLR grammar isn't able to handle the test source. I've created a PR in the ANTLR repository (antlr/grammars-v4#4160) that should fix these issues. I suggest we wait for that PR to be resolved before proceeding with this.
There is a second PR in the ANTLR repository regarding the usability of the generated AST: ANTLR PR