Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using Cython stable version #1412

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
+2 −6
Open

Using Cython stable version #1412

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ee03913
Using Cython stable version
ajsanchezsanz Nov 9, 2024
1ba867f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 9, 2024
7d7cdf2
Update CHANGES/1412.bugfix.rst
asvetlov Nov 14, 2024
98e7150
Update packaging/pep517_backend/_backend.py
asvetlov Nov 14, 2024
f0da051
Merge branch 'master' into fix/pulling_stable_cython_version
asvetlov Nov 14, 2024
c719a38
Fix changenote type
asvetlov Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES/1412.bugfix.rst
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change or symlink this to a packaging type.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't follow

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a packaging-focused change, not a runtime bug. It only affects people building from sdist or downstream packagers. Hence, it must show up in the packaging category of the changelog.

It is possible to either rename it to 1412.packaging.rst or commit a symlink. With a symlink in place, Towncrier will show this note in two places (bugfixes and packaging). Although, I'm not entirely sure whether it needs to be marked as a bug. Having a note for the downstream packagers is much more important.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.
Honestly I don't really care.
Let's rename a file extension without making a symlink

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Removed usage of Cython pre-release versions -- by :user:`ajsanchezsanz`, :user:`markgreene74`.
asvetlov marked this conversation as resolved.
Show resolved Hide resolved
7 changes: 1 addition & 6 deletions packaging/pep517_backend/_backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
from shutil import copytree
from sys import implementation as _system_implementation
from sys import stderr as _standard_error_stream
from sys import version_info as _python_version_tuple
from tempfile import TemporaryDirectory
from warnings import warn as _warn_that

Expand Down Expand Up @@ -82,9 +81,6 @@
PURE_PYTHON_ENV_VAR = 'YARL_NO_EXTENSIONS'
"""Environment variable name toggle used to opt out of making C-exts."""

IS_PY3_12_PLUS = _python_version_tuple[:2] >= (3, 12)
"""A flag meaning that the current runtime is Python 3.12 or higher."""

IS_CPYTHON = _system_implementation.name == "cpython"
"""A flag meaning that the current interpreter implementation is CPython."""

Expand Down Expand Up @@ -378,8 +374,7 @@ def get_requires_for_build_wheel(
)

c_ext_build_deps = [] if is_pure_python_build else [
'Cython >= 3.0.0b3' if IS_PY3_12_PLUS # Only Cython 3+ is compatible
else 'Cython',
'Cython >= 3.0.0, < 3.1.0',
asvetlov marked this conversation as resolved.
Show resolved Hide resolved
]

return _setuptools_get_requires_for_build_wheel(
Expand Down