Using Cython stable version #1412
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #1412 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1412 +/- ##
==========================================
- Coverage 96.06% 96.06% -0.01%
==========================================
Files 31 31
Lines 5765 5762 -3
Branches 344 344
==========================================
- Hits 5538 5535 -3
Misses 201 201
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ajsanchezsanz
force-pushed
the
fix/pulling_stable_cython_version
branch
from
88bad56
to
2e0c592
Compare
psf-chronographer
bot
added
the
bot:chronographer:provided
Co-authored-by: ajsanchezsanz <[email protected]> Co-authored-by: markgreene74 <[email protected]>
ajsanchezsanz
force-pushed
the
fix/pulling_stable_cython_version
branch
from
7f5b60c
to
ee03913
Compare
for more information, see https://pre-commit.ci
webknjaz
reviewed
Nov 9, 2024
There was a problem hiding this comment.
Let's change or symlink this to a packaging type.
| @@ -0,0 +1 @@ | |||
| Removed usage of Cython pre-release versions -- by :user:`ajsanchezsanz`, :user:`markgreene74`. | |||
There was a problem hiding this comment.
Suggested change
| Removed usage of Cython pre-release versions -- by :user:`ajsanchezsanz`, :user:`markgreene74`. | |
| Stopped implicitly allowing the use of Cython pre-release versions when | |
| building the distribution package -- by :user:`ajsanchezsanz` and | |
| :user:`markgreene74`. |
| @@ -378,8 +374,7 @@ def get_requires_for_build_wheel( | |||
| ) | |||
|
|
|||
| c_ext_build_deps = [] if is_pure_python_build else [ | |||
| 'Cython >= 3.0.0b3' if IS_PY3_12_PLUS # Only Cython 3+ is compatible | |||
| else 'Cython', | |||
| 'Cython >= 3.0.0, < 3.1.0', | |||
There was a problem hiding this comment.
Let's not put the lower limit for older CPython versions.
Suggested change
| 'Cython >= 3.0.0, < 3.1.0', | |
| 'Cython ~= 3.0.0; python_version >= "3.12"', | |
| 'Cython; python_version < "3.12"', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Use latest Cython stable version, avoiding using pre-release versions.
Why? There is some issue with Cython 3.1.0a1 that is making the tests to fail.
Are there changes in behavior for the user?
No
Related issue number
Fixes #1411
Checklist