Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RTP17g1 (no id in auto-re-enter if connid has changed) #215

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add RTP17g1 (no id in auto-re-enter if connid has changed) #215

wants to merge 1 commit into from

Commits on Oct 25, 2024

  1. Add RTP17g1 (no id in auto-re-enter if connid has changed) 

    This was a mistake in the protocol v2 spec. The id is included in the
re-enter so that the server can tell that this is an auto-re-enter (and
so does not represent a channel in the presence data), and so is safe to
idempotent-dedup if it's already in the presence set. But if the
connectionId has changed then it's not the same member.

(Not actually that big a deal, since it's a different member then it
won't be deduped anyway, the deduping logic only applies if the
memberKey is already present. But still, it's wrong to have the same
msgId)
    @SimonWoolf
    SimonWoolf committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    839be8b View commit details
    Browse the repository at this point in the history