Add RTP17g1 (no id in auto-re-enter if connid has changed) #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a mistake in the protocol v2 spec. The id is included in the re-enter so that the server can tell that this is an auto-re-enter (and so does not represent a channel in the presence data), and so is safe to idempotent-dedup if it's already in the presence set. But if the connectionId has changed then it's not the same member. (Not actually that big a deal, since it's a different member then it won't be deduped anyway, the deduping logic only applies if the memberKey is already present. But still, it's wrong to have the same msgId)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a mistake in the protocol v2 spec. The id is included in the re-enter so that the server can tell that this is an auto-re-enter (and so does not represent a channel in the presence data), and so is safe to idempotent-dedup if it's already in the presence set. But if the connectionId has changed then it's not the same member.
(Not actually that big a deal, since it's a different member then it won't be deduped anyway, the deduping logic only applies if the memberKey is already present. But still, it's wrong to have the same msgId)