add script for generating error constants #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows building outside og GOPATH
ORBAT
reviewed
Sep 3, 2018
scripts/errors-const/main.go
Outdated
| if err != nil { | ||
| log.Fatal(err) | ||
| } | ||
| var keys []int |
There was a problem hiding this comment.
More descriptive variable names woulod be good. Examples/suggestions: o --> opts, f --> outpFile m --> codeToDesc, keys --> codes, etc.
gernest
changed the title
|
@ORBAT I think this is ready for review |
|
Hey, how about reading the JSON file from an URL (with handling for |
|
@ORBAT I will add |
|
Closing this as per discussion on Slack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #32