Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate ably error status code #72

Merged
merged 4 commits into from
Sep 4, 2018
Merged

Generate ably error status code #72

merged 4 commits into from
Sep 4, 2018

Conversation

gernest
Copy link
Contributor

@gernest gernest commented Aug 31, 2018 •
edited
Loading

No description provided.

@gernest gernest mentioned this pull request Aug 31, 2018
Merged
@gernest gernest changed the title Generate ably error status code [WIP] Generate ably error status code Sep 4, 2018
@gernest gernest force-pushed the generate-ably-error-status-code branch from 7c54149 to 7af5814 Compare September 4, 2018 08:31
@gernest gernest changed the title [WIP] Generate ably error status code Generate ably error status code Sep 4, 2018
ORBAT
ORBAT approved these changes Sep 4, 2018
View reviewed changes
Copy link
Contributor

@ORBAT ORBAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ORBAT ORBAT merged commit 52edb00 into ably:integration-spec-1.1 Sep 4, 2018
@gernest gernest deleted the generate-ably-error-status-code branch September 4, 2018 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ORBAT ORBAT ORBAT approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gernest @ORBAT