Merge stable with changes from master #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
abishekvashok
commented
Mar 27, 2019
•
abishekvashok
commented
- Adds classical Japanese ccharacter support out of the box: Adds support for japanese characters #73
- New rainbow mode: 6ce59e9
- New lambda mode: 00ff332
- Adds support for cmake: CMake build system support #17
- Facilitates building without matrix fonts: c85f375
- Fixes various bugs Fix signal handlers and memory related bugs #26, Removes "./" from the commands #24, 704df61, b5c2543, 66a0be3, Merge acconfig.h into configure.ac per autoheader's warning #35, remove the "132x300" screen limit statement #37, Only restores TERM when it's changed. #36, Call time(NULL) and remove unused variable #41, afcc803, Small cmatrix.c fixes #66, Resolve issue #25 #67, -B (all bold) option does not work. #70, Fixes #68 (First symbol in a drawing line is green like others) #69
- Adds additional support information to Readme.md: dfae49d, 0cc3b18, be5567e, a8cb0fd, 9fffb25, 38647dd, cb6fe7c, aab39a9, 0096580
- Fixes Travis CI bugs and adds new test cases: Fixed Travis CI build #29, add osx build on Travis CI #39 ,21ffe61
cmatrix fonts doesnot work inside terminals, the configure.ac file has been modified to include a change which will inturn add an optional parameter for configure to disable installing the fonts. Signed-off-by: Abishek V Ashok <[email protected]>
Fixes window resize problem, earlier when the terminal window was resized to a size lesser than 3, a null pointer exception was invoked. Rainbow mode support gives users the choice of displaying the matrix in different colors using the -r option. Signed-off-by: Abishek V Ashok <[email protected]>
Code of conduct will help to facilitate healthy and constructive community behavior. It will also protect the developers and users of this project. This doc is recommended by Github. Signed-off-by: Abishek V Ashok <[email protected]>
Fixes bugs caused due to the disabling of matrix fonts option provided by commit:2869565. Adds a conditional variable (MATRIX_FONTS) whose value becomes true or false depending on whether enable_fonts variable has true as it's value which in turn depends whether the user has passed the --without-fonts flag. (enable_font is true if --without-fonts flag is not passed along with configure). The value of MATRIX_FONTS is checked in Makefile.am and another variable BUILD_FONTS to 0 or 1. install-data-local in Makefile.am checks for BUILD_FONTS and installs fonts if BUILD_FONTS is set to 1.
The outermost if condition in the Makefile requires to be prefixed with a @ symbol. make simply prints out the entire function even though it executes the function fine.
Readme.md file contained a typo, removes it. Signed-off-by: Abishek V Ashok <[email protected]>
This allows for easy copy&paste of build instructions,
and also generates nice output with pandoc now.
You may test that with:
pandoc -f markdown -t HTML README.md > README.html
use like this:
mkdir -p build
cd build
cmake ..
# or
#cmake -DCMAKE_INSTALL_PREFIX=/usr ..
make
Removes outdated information from Readme.md. Add code syntax markers and fixes minor typos
Adds a script to generate screenshots and screencasts. Integrated two of such screenshots into the readme.
Adds compiler information to .Travis.yml so that Travis compiles files with Clang as well.
If a user tries to run the commands as it is given it throws an error. bash: ./make: No such file or directory
Removes "./" from the commands in readme.md
Fixes the wrong sizeof in matrix allocation. Also improves the allocation strategy for the matrix, it allocates one contiguous array instead of allocating row by row. Properly free the matrix on reallocation. Fixes the memory leak on screen size change. Fixes uninitialized use of the bold attribute in the matrix by setting a default value of 0 in var_init(). The signal handlers were not safe. This commit moves the handling logic outside the handler functions and makes the handler set a global variable to indicate caught signals.
Adds CMake build system support
Fixed Travis CI build by touching the aclocal file so that the timestamp gets updated.
Remove autotools generated files match installation instruction described in README That is running configure in repo root, which is also convention. Also reshaping the script for a bit of readability.
* remove autoheader generated config.h.in and ignore cmatrix.spec They are missed in 5cfe816. * merge acconfig.h into configure.ac Per the following warning: autoheader-2.69: WARNING: Using auxiliary files such as `acconfig.h', `config.h.bot' autoheader-2.69: WARNING: and `config.h.top', to define templates for `config.h.in' autoheader-2.69: WARNING: is deprecated and discouraged. There is a difference in using `AH_TEMPLATE` inside `configure.ac` than an `acconfig.h`, the generated `config.h.in` won't have the five keys in beginning of the file, they are sorted and listed among all the keys, instead.
Only when `-f` force `TERM=linux` is used and there was a change of `$TERM`. Since, the forcing the TERM uses `putenv(3)`, replaced `system(3)` call to be consistent and to get rid of compilation warning of ignoring the return value. Note: using `setenv(3)` is cleaner, as we only needs to keep preserved TERM value, no need to format a `"TERM=foobar"` string. However, as the comment L388 stated that `putenv` is more common on non-Linux, so keeping this way.
* add osx builds on Travis CI * check headers in CMake and only include either of termios.h or termio.h CMake builds failed on basically 93fd357 [1] on OS X since termio.h isn't present. [1]: https://travis-ci.org/livibetter/cmatrix/builds/337114240 cmatrix.c do not need to include both termios.h and termio.h, the latter is a wrapper on Linux, on POSIX, the former would do. CMake should check the header files, not defining blindly, although it's not needed as now cmatrix.c only includes one of the headers, however, it's a good practice, but it should also halt the build process if neither is found.
This partially undoes commit 66a0be3 ("`va_system()`: rename buffer variable and make buffer size a variable"). The size of the buffer can be determined using the sizeof keyword. Furthermore, it is not necessary to subtract 1 from the size. From the manual page: "The functions snprintf() and vsnprintf() write at most size bytes (including the terminating null byte ('\0')) to str."
On UNIXoids, environment variables are process-local and destroyed when a process exits. Thus the code at the end of main that tries to restore TERM to its previous value can never have had the desired effect. Even after this change, running cmatrix -f does not set TERM=linux for the calling shell.
putenv was the old standard. Now setenv has also made it's way to the set of UNIX standards. Considering the current buggy nature of putenv doing a migration to setenv. Fixes #38 Signed-off-by: Abishek V Ashok <[email protected]>
Adds .R to facilitate integration of rultor.
Adds cmake generated build files and local cache to .gitignore so that it would not be tracked by git. Fixes #52 Signed-off-by: Abishek V Ashok <[email protected]>
Simplifies and beautifies the process which implements multiple levels of boldness to the text in cmatrix. Fixes #53 Signed-off-by: Abishek V Ashok <[email protected]>
Added an option to lock computer
New feature: Lambda mode
Fix c_die function, now it prints msg. Remove spaces at the end of lines. Remove redundant srand(...) usage. Signed-off-by: Andrey Abramov <[email protected]>
This should resolve issue #25 (exit on first keystroke should print the keystroke on the terminal). Signed-off-by: Andrey Abramov <[email protected]>
Signed-off-by: Andrey Abramov <[email protected]>
Small cmatrix.c fixes
Resolve issue #25
Fixes #70 (-B (all bold) option does not work.) Signed-off-by: Andrey Abramov <[email protected]>
Fix typo. The case when we don't have both "setfont" and "consolechars" is considered. Signed-off-by: Andrey Abramov <[email protected]>
Small fixes about -l option
Fix #70 (-B (all bold) option does not work.)
Fixes #68 (First symbol in a drawing line is green like others) Signed-off-by: Andrey Abramov <[email protected]>
Signed-off-by: Andrey Abramov <[email protected]>
Fixes #68 (First symbol in a drawing line is green like others)
Adds classic mode which can be invoked with "c", which uses Japanese characters instead of the regular English characters that cmatrix outputed earlier. Done to match up with the original matrix. The starting, ending, and range for randum number (corresponding to the unicode character) is modified to suite the Japanese character range. Requires appropriate Japanese fonts to make it work. Fixes #57 Signed-off-by: Abishek V Ashok <[email protected]>
Modifies code to calculate randnum from values of highnum and randmin which are used for matrix randum unicode generation. The last implementation contained hardcoded values. Signed-off-by: Abishek V Ashok <[email protected]>
Adds support for japanese characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.