Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor doc updates #8833

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Minor doc updates #8833

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6217514
qualify trusted-for-what
zancas Sep 3, 2024
31511d5
change from 'read' as this is difficult to parse, especially for non-…
zancas Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions zebra-rpc/src/sync.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,12 @@ use crate::{
/// See the [`TrustedChainSync::wait_for_chain_tip_change()`] method documentation for more information.
const POLL_DELAY: Duration = Duration::from_millis(200);

/// Syncs non-finalized blocks in the best chain from a trusted Zebra node's RPC methods.
/// Syncs non-finalized blocks in the best chain from a trusted-for-block-validation Zebra node's RPC methods.
#[derive(Debug)]
struct TrustedChainSync {
/// RPC client for calling Zebra's RPC methods.
rpc_client: RpcRequestClient,
/// The read state service.
/// The recorded-state service.
Copy link
Contributor

@arya2 arya2 Sep 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// The recorded-state service.
/// A read-only (secondary RocksDB instance) handle to Zebra's database.

db: ZebraDb,
/// The non-finalized state - currently only contains the best chain.
non_finalized_state: NonFinalizedState,
Expand Down
Loading