Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor doc updates #8833

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Minor doc updates #8833

wants to merge 2 commits into from

Conversation

zancas
Copy link
Contributor

@zancas zancas commented Sep 3, 2024

Motivation

Solution

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@zancas zancas requested a review from a team as a code owner September 3, 2024 14:48
@zancas zancas requested review from arya2 and removed request for a team September 3, 2024 14:48
arya2
arya2 reviewed Sep 5, 2024
View reviewed changes
zebra-rpc/src/sync.rs
#[derive(Debug)]
struct TrustedChainSync {
/// RPC client for calling Zebra's RPC methods.
rpc_client: RpcRequestClient,
/// The read state service.
/// The recorded-state service.
Copy link
Contributor

@arya2 arya2 Sep 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// The recorded-state service.
/// A read-only (secondary RocksDB instance) handle to Zebra's database.

@arya2
Copy link
Contributor

arya2 commented Sep 5, 2024

This looks good pending one suggestion, thank you for the change!

@arya2 arya2 added the S-waiting-on-author Status: waiting on the ticket or PR author label Oct 4, 2024
@oxarbitrage
Copy link
Contributor

@zancas I can't add @arya2 suggestion to this pull request as the branch is in the zingolabs repository. Do you want to add it ? I think it will be good to do so.

@oxarbitrage oxarbitrage added the do-not-merge Tells Mergify not to merge this PR label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arya2 arya2 arya2 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
do-not-merge Tells Mergify not to merge this PR S-waiting-on-author Status: waiting on the ticket or PR author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zancas @arya2 @oxarbitrage