Implement the messages spec #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: teor <[email protected]>
Co-authored-by: teor <[email protected]>
Co-authored-by: teor <[email protected]>
teor2345
reviewed
Jun 2, 2021
| @@ -66,7 +66,7 @@ impl<T: SigType> Hash for VerificationKeyBytes<T> { | |||
| /// | |||
| /// 1. The check that the bytes are a canonical encoding of a verification key; | |||
| /// 2. The check that the verification key is not a point of small order. | |||
| #[derive(Copy, Clone, Debug)] | |||
| #[derive(PartialEq, Copy, Clone, Debug)] | |||
There was a problem hiding this comment.
Security: we might want to implement constant-time equality instead.
@dconnolly what do you think?
teor2345
reviewed
Jun 2, 2021
teor2345
reviewed
Jun 2, 2021
teor2345
reviewed
Jun 2, 2021
jvff
reviewed
Jun 2, 2021
This was referenced Jun 7, 2021
|
@oxarbitrage can we get a quick rebase onto main to resolve some merge conflicts? thanks |
|
I don't see merge conflicts and i actually think nothing was merged into the |
|
I think this PR can also close #48. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ongoing implementation of the messages spec.
https://github.com/ZcashFoundation/redjubjub/tree/main/rfcs/0001-messages.md
More details to be added.