Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bincode serialization of Enum #119

Open
oxarbitrage opened this issue Jun 7, 2021 · 0 comments
Open

bincode serialization of Enum #119

oxarbitrage opened this issue Jun 7, 2021 · 0 comments
Assignees
@dconnolly @chelseakomlo
Labels
frost

Comments

@oxarbitrage
Copy link
Contributor

bincode serializes the Enums starting with u32. We have the MsgType enum introduced by the spec (https://github.com/ZcashFoundation/redjubjub/blob/fa74969d5653c620e831c8c51c096f051527d958/rfcs/0001-messages.md#header) that says this should be an u8.

We can change the spec or manually serialize/deserialize MsgType: #114 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dconnolly dconnolly

@chelseakomlo chelseakomlo

Labels
frost
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dconnolly @chelseakomlo @oxarbitrage @ftm1000