Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum participant constraints #453

Merged
merged 6 commits into from
Aug 16, 2023
Merged

Add minimum participant constraints #453

merged 6 commits into from
Aug 16, 2023

Conversation

natalieesk
Copy link
Contributor

This closes #443

@natalieesk natalieesk changed the title Add minimum Participant Constraint Enforcement Improvements Add minimum participant constraints Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.40% 🎉

Comparison is base (ad07c9e) 76.83% compared to head (7c706db) 77.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #453      +/-   ##
==========================================
+ Coverage   76.83%   77.23%   +0.40%     
==========================================
  Files          30       30              
  Lines        2672     2706      +34     
==========================================
+ Hits         2053     2090      +37     
+ Misses        619      616       -3     
Files Changed Coverage Δ
frost-core/src/frost/keys.rs 92.16% <100.00%> (+0.80%) ⬆️
frost-core/src/frost/keys/dkg.rs 88.11% <100.00%> (-0.24%) ⬇️
frost-core/src/frost/keys/repairable.rs 97.05% <100.00%> (+0.18%) ⬆️
frost-ed25519/src/keys/repairable.rs 59.09% <100.00%> (+9.09%) ⬆️
frost-ed448/src/keys/repairable.rs 59.09% <100.00%> (+9.09%) ⬆️
frost-p256/src/keys/repairable.rs 59.09% <100.00%> (+9.09%) ⬆️
frost-ristretto255/src/keys/repairable.rs 60.86% <100.00%> (+8.23%) ⬆️
frost-secp256k1/src/keys/repairable.rs 59.09% <100.00%> (+9.09%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Do you want to include the new findings in this PR too?

  • DKG part1()
  • repair_share_step_1()

Also needs rebasing

Copy link
Contributor

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

mergify bot added a commit that referenced this pull request Aug 16, 2023
@mergify mergify bot merged commit bb94a34 into main Aug 16, 2023
15 checks passed
@mergify mergify bot deleted the min_participant_443 branch August 16, 2023 18:38
@mpguerra mpguerra mentioned this pull request Aug 23, 2023
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NCC-E008263-XLV] frost-core: Minimum Participant Constraint Enforcement Improvements
2 participants