Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Think about validating inputs in keygen_with_dealer and not just in generate_secret_polynomial #327

Closed
natalieesk opened this issue Apr 26, 2023 · 1 comment
Labels
frost-core Work for the `frost-core` generic implementation

Comments

@natalieesk
Copy link
Contributor

Currently we handle validation of min_signers and max_signers in generate_secret_polynomial. When calling keygen_with_dealer we accept these inputs but perform no validation on them until generate_secret_polynomial is called. generate_secret_polynomial is public and so if it's directly accessible we probably would want to validate the inputs in that function however. We should consider how best to handle validation in this instance as we would reduce computation effort by performing those validations up front.

@natalieesk natalieesk added the frost-core Work for the `frost-core` generic implementation label Apr 26, 2023
@conradoplg
Copy link
Contributor

Done in #453 after the audit found an issue related to this (good job anticipating it 😆 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frost-core Work for the `frost-core` generic implementation
Projects
Archived in project
Development

No branches or pull requests

2 participants