Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce minimum protocol version #18

Merged
merged 3 commits into from
Jun 7, 2022
Merged

Enforce minimum protocol version #18

merged 3 commits into from
Jun 7, 2022

Conversation

conradoplg
Copy link
Contributor

Part of #10

Depends on ZcashFoundation/btcd#2 and #17

conradoplg
conradoplg commented Jun 3, 2022
View reviewed changes
go.mod Outdated Show resolved Hide resolved
teor2345
teor2345 suggested changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like us to consider using a per-network minimum protocol version, because it provides more reliable peers from the seeder.

zcash/client.go Outdated Show resolved Hide resolved
@conradoplg conradoplg mentioned this pull request Jun 6, 2022
Merged
teor2345
teor2345 approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the versions and ports!

zcash/client.go Show resolved Hide resolved
@conradoplg conradoplg mentioned this pull request Jun 7, 2022
Merged
@conradoplg conradoplg changed the base branch from filter-peers-non-std-port to master June 7, 2022 00:09
conradoplg
conradoplg commented Jun 7, 2022
View reviewed changes
Copy link
Contributor Author

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased on the previous PR after it merged and pointed to the merged btcd

go.mod Outdated Show resolved Hide resolved
teor2345
teor2345 approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'll leave you to do the merge

@conradoplg conradoplg merged commit 309a006 into master Jun 7, 2022
@conradoplg conradoplg mentioned this pull request Jun 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@conradoplg @teor2345