Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce the minimum protocol version #10

Closed
teor2345 opened this issue May 6, 2021 · 1 comment
Closed

Enforce the minimum protocol version #10

teor2345 opened this issue May 6, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@teor2345
Copy link
Contributor

teor2345 commented May 6, 2021 •
edited
Loading

Currently, https://github.com/gtank/btcd/blob/master/peer/peer.go sets the MinAcceptableProtocolVersion to a recent bitcoin network protocol version.

But for Zcash, we want it to be the most recently activated network upgrade.

We might even want it to be configurable per-network (see #3).
@teor2345 teor2345 added the bug Something isn't working label May 6, 2021
@teor2345 teor2345 mentioned this issue Sep 30, 2021
Closed
5 tasks
@teor2345 teor2345 mentioned this issue Oct 11, 2021
Closed
9 tasks
@conradoplg conradoplg mentioned this issue Mar 29, 2022
Merged
This was referenced May 31, 2022
Closed
Closed
This was referenced Jun 3, 2022
Merged
Merged
@conradoplg
Copy link
Contributor

Done in #18 and other PRs that deployed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@conradoplg @teor2345