Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup extra code in headers #1914

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Cleanup extra code in headers #1914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2321cc1
Remove extra code from AIEGenerateColumnControlOverlay.h
fifield Nov 12, 2024
7daeb90
Remove extra code from AIEAssignBufferDescriptorIDs.h
fifield Nov 12, 2024
9c7c150
Update AIEGenerateColumnControlOverlay.h
fifield Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 2 additions & 21 deletions include/aie/Dialect/AIE/Transforms/AIEAssignBufferDescriptorIDs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,27 +11,8 @@
#ifndef AIE_ASSIGN_BUFFER_DESCRIPTOR_IDS_H
#define AIE_ASSIGN_BUFFER_DESCRIPTOR_IDS_H

#include <optional>
#include "aie/Dialect/AIE/IR/AIETargetModel.h"

#include "aie/Dialect/AIE/IR/AIEDialect.h"
#include "aie/Dialect/AIE/Transforms/AIEAssignBufferDescriptorIDs.h"
#include "aie/Dialect/AIE/Transforms/AIEPasses.h"

#include "mlir/Pass/Pass.h"

using namespace mlir;
using namespace xilinx;
using namespace xilinx::AIE;

#include "aie/Dialect/AIE/IR/AIEDialect.h"
#include "aie/Dialect/AIE/Transforms/AIEPasses.h"

#include "mlir/Pass/Pass.h"

#define DEBUG_TYPE "aie-assign-bd-ids"

using namespace mlir;
using namespace xilinx;
using namespace xilinx::AIE;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the seasonal cleaning!
Even the last one is too much for my taste, but it would be probably too extreme for now. 😃

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the seasonal cleaning! Even the last one is too much for my taste, but it would be probably too extreme for now. 😃

yeah it's a slippery slope. Before you know it you're "cleaning" every file in the repo.


struct BdIdGenerator {
Expand All @@ -51,4 +32,4 @@ struct BdIdGenerator {
void freeBdId(uint32_t bdId);
};

#endif
#endif
19 changes: 1 addition & 18 deletions include/aie/Dialect/AIE/Transforms/AIEGenerateColumnControlOverlay.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,26 +11,9 @@
#ifndef AIE_ASSIGN_BUFFER_DESCRIPTOR_IDS_H
#define AIE_ASSIGN_BUFFER_DESCRIPTOR_IDS_H

#include <optional>

#include "aie/Dialect/AIE/IR/AIEDialect.h"
#include "aie/Dialect/AIE/Transforms/AIEPasses.h"

#include "mlir/Pass/Pass.h"

using namespace mlir;
using namespace xilinx;
using namespace xilinx::AIE;

#include "aie/Dialect/AIE/IR/AIEDialect.h"
#include "aie/Dialect/AIE/Transforms/AIEPasses.h"

#include "mlir/Pass/Pass.h"

#define DEBUG_TYPE "aie-generate-column-control-overlay"

using namespace mlir;
using namespace xilinx;
using namespace xilinx::AIE;

// Populate column control streaming interconnect overlay
Expand All @@ -44,7 +27,7 @@ DenseMap<int, int> getRowToShimChanMap(const AIETargetModel &targetModel,

// AIE arch-specific tile id to controller id mapping. Users can use those
// packet ids for design but run into risk of deadlocking control packet flows.
DenseMap<AIE::TileID, int>
DenseMap<TileID, int>
getTileToControllerIdMap(bool clColumnWiseUniqueIDs,
const AIETargetModel &targetModel);

Expand Down
Loading