Cleanup extra code in headers #1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup header file
update header file
fifield
requested review from
AndraBisca and
stephenneuendorffer
as code owners
Coverage ReportCreated: 2024-11-12 18:15Click here for information about interpreting this report.
Generated by llvm-cov -- llvm version 14.0.0 |
jgmelber
approved these changes
Nov 12, 2024
keryell
approved these changes
Nov 12, 2024
| #define DEBUG_TYPE "aie-assign-bd-ids" | ||
|
|
||
| using namespace mlir; | ||
| using namespace xilinx; | ||
| using namespace xilinx::AIE; |
There was a problem hiding this comment.
Thanks for all the seasonal cleaning!
Even the last one is too much for my taste, but it would be probably too extreme for now. 😃
There was a problem hiding this comment.
Thanks for all the seasonal cleaning! Even the last one is too much for my taste, but it would be probably too extreme for now. 😃
yeah it's a slippery slope. Before you know it you're "cleaning" every file in the repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup some extra code in a couple header files. I bumped into this because of some compiler warnings regarding redefinition of
DEBUG_TYPE, which shouldn't be in header files anyway.