-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Console log updates #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far so good, go through the rest of the modules and add logs whenever you see something important happening, (adding waypoints, changing drone modes, initializing objects, etc.)
@@ -0,0 +1,9 @@ | |||
import 'dart:developer'; | |||
|
|||
void logDroneMode(int? currentMode, String? currentModeName) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is making it to complicated, I see where you're coming from but I think it's better to keep it in the widget
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good progress so far! We need a lot more information from mavlink_communication.dart, like when we the TCP ports and Serial ports are initialized, when instructions are written, etc.
flutter_app/lib/command_constructors/create_waypoint_constructor.dart
Outdated
Show resolved
Hide resolved
break; | ||
case MavlinkCommunicationType.serial: | ||
_startupSerialPort(connectionAddress); | ||
log('Started listening for a Serial connection'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be able to merge soon! I left some nitpicks, other than that you have to restore the home_screen
to how it is in main. Also if you have time, maybe add the name of the component the log is from in the log, not necessary but really nice to have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A single nitpick, otherwise you're basically done
mavModeGuidedArmed: "Guided Armed", | ||
mavModeAutoArmed: "Auto Armed", | ||
}; | ||
const String moduleName = "Change Drone Mode Widget"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: change to widgetName
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
No description provided.