Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PSR-12 Coding Standards and Add CS Check to CI Flow #122

Merged
merged 12 commits into from
Oct 5, 2023
Merged

Implement PSR-12 Coding Standards and Add CS Check to CI Flow #122

merged 12 commits into from
Oct 5, 2023

Conversation

salehhashemi1992
Copy link
Contributor

@salehhashemi1992 salehhashemi1992 commented Oct 4, 2023 •
edited
Loading

Changes

  • Updated GitHub Actions workflow to include a CS check step
  • Fixed all existing CS errors to comply with PSR-12
  • Fix some bugs in test cases and the usage of assertions
  • change the PHP version to 7.4 because of typed properties usage in some files

@salehhashemi1992 salehhashemi1992 force-pushed the ci/setup-code-style-check branch 4 times, most recently from 452d4dd to c9734d5 Compare October 4, 2023 07:25
@salehhashemi1992 salehhashemi1992 force-pushed the ci/setup-code-style-check branch 3 times, most recently from 93a1830 to ebd1fa8 Compare October 4, 2023 18:13
@salehhashemi1992 salehhashemi1992 force-pushed the ci/setup-code-style-check branch 3 times, most recently from 2c51d09 to 45fe595 Compare October 4, 2023 20:29
@salehhashemi1992 salehhashemi1992 changed the title add cs checking to ci flow Implement PSR-12 Coding Standards and Add CS Check to CI Flow Oct 4, 2023
@salehhashemi1992 salehhashemi1992 marked this pull request as ready for review October 4, 2023 20:44
@salehhashemi1992 salehhashemi1992 mentioned this pull request Oct 4, 2023
Closed
darwinz
darwinz reviewed Oct 5, 2023
View reviewed changes
Maths/Factorial.php Outdated Show resolved Hide resolved
darwinz
darwinz reviewed Oct 5, 2023
View reviewed changes
Maths/Factorial.php Outdated Show resolved Hide resolved
darwinz
darwinz reviewed Oct 5, 2023
View reviewed changes
Maths/Factorial.php Outdated Show resolved Hide resolved
darwinz
darwinz reviewed Oct 5, 2023
View reviewed changes
Searches/JumpSearch.php Outdated Show resolved Hide resolved
darwinz
darwinz reviewed Oct 5, 2023
View reviewed changes
Searches/TernarySearch.php Outdated Show resolved Hide resolved
darwinz
darwinz reviewed Oct 5, 2023
View reviewed changes
Searches/TernarySearch.php Outdated Show resolved Hide resolved
darwinz
darwinz reviewed Oct 5, 2023
View reviewed changes
Searches/TernarySearch.php Outdated Show resolved Hide resolved
darwinz
darwinz reviewed Oct 5, 2023
View reviewed changes
Sorting/HeapSort.php Outdated Show resolved Hide resolved
darwinz
darwinz reviewed Oct 5, 2023
View reviewed changes
Sorting/HeapSort.php Outdated Show resolved Hide resolved
darwinz
darwinz reviewed Oct 5, 2023
View reviewed changes
Strings/CountVowels.php Outdated Show resolved Hide resolved
darwinz
darwinz reviewed Oct 5, 2023
View reviewed changes
Strings/CountVowels.php Outdated Show resolved Hide resolved
darwinz
darwinz reviewed Oct 5, 2023
View reviewed changes
Strings/MaxCharacter.php Outdated Show resolved Hide resolved
darwinz
darwinz approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@darwinz darwinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing all of this cleanup. This is awesome!

@salehhashemi1992
Copy link
Contributor Author

Thank you for doing all of this cleanup. This is awesome!

You're welcome! Such an honor for me to be part of this awesome repository.

@darwinz darwinz merged commit 618fe7f into TheAlgorithms:master Oct 5, 2023
2 checks passed
@darwinz
Copy link
Contributor

darwinz commented May 17, 2024

#118

@darwinz darwinz linked an issue May 17, 2024 that may be closed by this pull request
Standard structure for algorithms #118
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darwinz darwinz Awaiting requested review from darwinz

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Standard structure for algorithms
2 participants
@salehhashemi1992 @darwinz