New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PSR-12 Coding Standards and Add CS Check to CI Flow #122

Merged

darwinz merged 12 commits into TheAlgorithms:master from salehhashemi1992:ci/setup-code-style-check

Oct 5, 2023

Contributor

salehhashemi1992 commented Oct 4, 2023 •

edited

Loading

Changes

Updated GitHub Actions workflow to include a CS check step
Fixed all existing CS errors to comply with PSR-12
Fix some bugs in test cases and the usage of assertions
change the PHP version to 7.4 because of typed properties usage in some files

salehhashemi1992 force-pushed the ci/setup-code-style-check branch 4 times, most recently from 452d4dd to c9734d5 Compare

October 4, 2023 07:25

salehhashemi1992 added 2 commits

October 4, 2023 21:38


          add cs checking to ci flow

ca17a0d


          excluding namespace errors from cs check

d7d34e3

salehhashemi1992 force-pushed the ci/setup-code-style-check branch 3 times, most recently from 93a1830 to ebd1fa8 Compare

October 4, 2023 18:13


          fix cs errors to follow the psr12 standard and also some minor fixes

9c27262

salehhashemi1992 force-pushed the ci/setup-code-style-check branch from ebd1fa8 to 9c27262 Compare

October 4, 2023 18:20

salehhashemi1992 added 6 commits

October 4, 2023 22:56


          fix string test structure

39ab69e


          fix searches test structure

963bafc


          fix maths test structure

a305f06


          fix conversions test structure

e5523e0


          fix morse test structure

1a04f5e


          fix mono alphabetic cipher test structure

salehhashemi1992 force-pushed the ci/setup-code-style-check branch 3 times, most recently from 2c51d09 to 45fe595 Compare

October 4, 2023 20:29


          fix some ci warnings

b814cf2

salehhashemi1992 force-pushed the ci/setup-code-style-check branch from 45fe595 to b814cf2 Compare

October 4, 2023 20:31


          ignoring warnings in cs checker

29db480

salehhashemi1992 changed the title ~~add cs checking to ci flow~~ Implement PSR-12 Coding Standards and Add CS Check to CI Flow

salehhashemi1992 marked this pull request as ready for review

October 4, 2023 20:44

salehhashemi1992 mentioned this pull request

Standard structure for algorithms #118

Closed

darwinz reviewed

View reviewed changes

Ciphers/MonoAlphabeticCipher.php Outdated Show resolved Hide resolved

darwinz reviewed

View reviewed changes

DataStructures/SinglyLinkedList.php Outdated Show resolved Hide resolved

darwinz reviewed

View reviewed changes

Maths/Factorial.php Outdated Show resolved Hide resolved

darwinz reviewed

View reviewed changes

Maths/Factorial.php Outdated Show resolved Hide resolved

darwinz reviewed

View reviewed changes

Maths/Factorial.php Outdated Show resolved Hide resolved

darwinz reviewed

View reviewed changes

Searches/ExponentialSearch.php Outdated Show resolved Hide resolved

darwinz reviewed

View reviewed changes

Searches/ExponentialSearch.php Outdated Show resolved Hide resolved

darwinz reviewed

View reviewed changes

Searches/InterpolationSearch.php Outdated Show resolved Hide resolved

darwinz reviewed

View reviewed changes

Searches/JumpSearch.php Outdated Show resolved Hide resolved

darwinz reviewed

View reviewed changes

Searches/TernarySearch.php Outdated Show resolved Hide resolved

darwinz reviewed

View reviewed changes

Searches/TernarySearch.php Outdated Show resolved Hide resolved

darwinz reviewed

View reviewed changes

Searches/TernarySearch.php Outdated Show resolved Hide resolved

salehhashemi1992 force-pushed the ci/setup-code-style-check branch from ae6df33 to 4ed1156 Compare

October 5, 2023 06:31

darwinz reviewed

View reviewed changes

Sorting/HeapSort.php Outdated Show resolved Hide resolved

darwinz reviewed

View reviewed changes

Sorting/HeapSort.php Outdated Show resolved Hide resolved

darwinz reviewed

View reviewed changes

Strings/CountVowels.php Outdated Show resolved Hide resolved

darwinz reviewed

View reviewed changes

Strings/CountVowels.php Outdated Show resolved Hide resolved

darwinz reviewed

View reviewed changes

Strings/MaxCharacter.php Outdated Show resolved Hide resolved

salehhashemi1992 force-pushed the ci/setup-code-style-check branch from 4ed1156 to 6e797ce Compare

October 5, 2023 06:37

darwinz approved these changes

View reviewed changes

Contributor

darwinz left a comment

Thank you for doing all of this cleanup. This is awesome!


          fix comment indents and docs

658618a

darwinz added the hacktoberfest-accepted label

salehhashemi1992 force-pushed the ci/setup-code-style-check branch from 6e797ce to 658618a Compare

October 5, 2023 06:41

Contributor Author

salehhashemi1992 commented Oct 5, 2023

Thank you for doing all of this cleanup. This is awesome!

You're welcome! Such an honor for me to be part of this awesome repository.

salehhashemi1992 requested a review from darwinz

October 5, 2023 06:43

darwinz merged commit 618fe7f into TheAlgorithms:master

2 checks passed

Contributor

darwinz commented May 17, 2024

darwinz linked an issue

that may be closed by this pull request

Standard structure for algorithms #118

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted