Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard structure for algorithms #118

Closed
salehhashemi1992 opened this issue Sep 16, 2023 · 4 comments · Fixed by #122
Closed

Standard structure for algorithms #118

salehhashemi1992 opened this issue Sep 16, 2023 · 4 comments · Fixed by #122

Comments

@salehhashemi1992
Copy link
Contributor

first of all, Thank you for this helpful repo.
I've noticed that some algorithms are implemented as functions, while others are implemented using classes and methods.

To maintain consistency, it would be beneficial to define a standard coding style, such as adhering to a specific PSR, namespace, or any other structural guidelines for contributions. This way, all algorithms will follow the same structure, making it easier to understand and contribute to the project.

@salehhashemi1992
Copy link
Contributor Author

it takes a lot of time but I can add autoload and namespaces to the project and also code sniffer

@darwinz
Copy link
Contributor

darwinz commented Oct 3, 2023

Thanks @salehhashemi1992 . I don't think we need to go as far as adding autoload and namespaces across the project. I do agree that keeping a consistent styling is important though.

@darwinz
Copy link
Contributor

darwinz commented Oct 4, 2023

We've tried to stick to the PSR-12 style guide, found here

@salehhashemi1992
Copy link
Contributor Author

So I've done some tweaks here: #122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants